Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.32] 2025 January Backports #11583

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

dereknola
Copy link
Member

Proposed Changes

Backports of

Types of Changes

Verification

Testing

Linked Issues

#11575
#11579

User-Facing Change


Further Comments

…1485)

* Add "k3s certificate check" clause for better test coverage

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add table support to cert check

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner January 13, 2025 17:25
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 32.69231% with 35 lines in your changes missing coverage. Please review.

Project coverage is 47.79%. Comparing base (cca8fac) to head (5d3eeb8).
Report is 17 commits behind head on release-1.32.

Files with missing lines Patch % Lines
pkg/cli/cert/cert.go 25.53% 31 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.32   #11583      +/-   ##
================================================
+ Coverage         43.85%   47.79%   +3.94%     
================================================
  Files               181      185       +4     
  Lines             18812    19265     +453     
================================================
+ Hits               8250     9208     +958     
+ Misses             9353     8729     -624     
- Partials           1209     1328     +119     
Flag Coverage Δ
e2etests 40.58% <9.61%> (+4.79%) ⬆️
inttests 35.14% <32.69%> (+0.04%) ⬆️
unittests 17.03% <0.00%> (+2.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 0b41471 into k3s-io:release-1.32 Jan 13, 2025
39 checks passed
@dereknola dereknola deleted the jan_bckprt_1.32 branch January 16, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants